From: Vivek Goyal <vgoyal@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Do background CIL flushes via a workqueue
Date: Tue, 27 Mar 2012 13:23:57 -0400 [thread overview]
Message-ID: <20120327172357.GE28707@redhat.com> (raw)
In-Reply-To: <20120327170309.GA6712@infradead.org>
On Tue, Mar 27, 2012 at 01:03:09PM -0400, Christoph Hellwig wrote:
> On Tue, Mar 27, 2012 at 12:19:41PM -0400, Vivek Goyal wrote:
> > So xfs either need to resort to similar optimizaiton where IO type from
> > both the process context is of same type or try to do all the IO from
> > one process context.
>
> All XFS log I/O is marked SYNC and (FUA and/or FLUSH).
Well, if all the requests are marked with FUA/FLUSH, then I think these
requests will not even be given to IO scheduler. And we should not have
the issue of idling.
if (bio->bi_rw & (REQ_FLUSH | REQ_FUA)) {
spin_lock_irq(q->queue_lock);
where = ELEVATOR_INSERT_FLUSH;
goto get_rq;
}
Thanks
Vivek
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-27 17:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 9:46 [PATCH] xfs: Do background CIL flushes via a workqueue Dave Chinner
2012-03-27 14:31 ` Christoph Hellwig
2012-03-27 15:57 ` Vivek Goyal
2012-03-27 16:03 ` Christoph Hellwig
2012-03-27 16:19 ` Vivek Goyal
2012-03-27 17:03 ` Christoph Hellwig
2012-03-27 17:18 ` Vivek Goyal
2012-03-27 17:23 ` Vivek Goyal [this message]
2012-03-29 8:52 ` Dave Chinner
2012-03-29 8:51 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327172357.GE28707@redhat.com \
--to=vgoyal@redhat.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox