From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix buffer lookup race on allocation failure
Date: Thu, 29 Mar 2012 15:07:59 -0400 [thread overview]
Message-ID: <20120329190759.GA8622@infradead.org> (raw)
In-Reply-To: <1333022846-12697-1-git-send-email-david@fromorbit.com>
I don't like this solution. What speaks against building up the page
array after the first buffer lookup failed, but before linking the
buffer into the rbtree? That's the the inode cache and all the VFS
caches do.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-29 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 12:07 [PATCH] xfs: fix buffer lookup race on allocation failure Dave Chinner
2012-03-29 16:53 ` Mark Tinguely
2012-03-29 19:07 ` Christoph Hellwig [this message]
2012-03-29 21:04 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329190759.GA8622@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox