From: Dave Chinner <david@fromorbit.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>, xfs@oss.sgi.com
Subject: Re: detecting case-insensitivity
Date: Tue, 10 Apr 2012 08:19:46 +1000 [thread overview]
Message-ID: <20120409221946.GL18323@dastard> (raw)
In-Reply-To: <20120409212833.GA10508@fieldses.org>
On Mon, Apr 09, 2012 at 05:28:33PM -0400, J. Bruce Fields wrote:
> > > From: Dave Chinner <david@fromorbit.com>
> > > Date: 09.04.2012 03.30
> > >
> > > On Sat, Apr 07, 2012 at 10:00:29AM -0400, J. Bruce Fields wrote:
> > > > Is there a generic way to detect whether a given filesystem is
> > > > case-insensitive? If not, how should it be done? (A bit in s_flags?)
> > >
> > > I don't think there is a generic flag for it. We could trivially add
> > > one, I think, as it is generally a fixed property for the entire
> > > filesystem....
>
> So, I assume the following is totally wrong, but the basic idea (create
> a new flag, set it based on xfs_sb_version_hasasciici, check it in nfsd)
> would work?
Looks mostly OK to me.
> On Mon, Apr 09, 2012 at 09:01:11AM +0400, Vyacheslav Dubeyko wrote:
> > But why does it need to detect that filesystem case-insensitive or not? In what use-case does it need to make such detection?
>
> To be honest, I have no idea--it's not a mandatory attribute, so I think
> I'll instead just ceasing to support the attribute and seeing if anyone
> complains....
I suspect that there are some applications out there that might care
that Bruce and bruce are the same file for matching purposes (e.g. a
file manager)
....
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 7423d71..890f439 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -1458,7 +1458,7 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp,
> switch (createmode) {
> case NFS3_CREATE_UNCHECKED:
> if (! S_ISREG(dchild->d_inode->i_mode))
> - err = nfserr_exist;
> + goto out;
Not sure what this change is for, though....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-04-09 22:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 5:01 detecting case-insensitivity Vyacheslav Dubeyko
2012-04-09 21:28 ` J. Bruce Fields
2012-04-09 22:19 ` Dave Chinner [this message]
2012-04-09 22:27 ` J. Bruce Fields
2012-04-09 22:44 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2012-04-07 14:00 J. Bruce Fields
2012-04-08 23:02 ` Dave Chinner
2012-04-11 20:03 ` Christoph Hellwig
2012-04-11 20:37 ` J. Bruce Fields
2012-04-30 21:26 ` J. Bruce Fields
2012-04-30 23:01 ` Dave Chinner
2012-05-03 20:22 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120409221946.GL18323@dastard \
--to=david@fromorbit.com \
--cc=bfields@fieldses.org \
--cc=slava@dubeyko.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox