public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: Ben Myers <bpm@sgi.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: don't fill statvfs with project quota for a directory if it was not enabled.
Date: Wed, 11 Apr 2012 15:59:15 -0400	[thread overview]
Message-ID: <20120411195915.GA28816@infradead.org> (raw)
In-Reply-To: <4F77DFDB.1040802@oracle.com>

Sorry for taking so long to get back to this, but conferences and work
kept me really busy the last two weeks.

> -	if ((ip->i_d.di_flags & XFS_DIFLAG_PROJINHERIT) ||
> -	    ((mp->m_qflags & (XFS_PQUOTA_ACCT|XFS_OQUOTA_ENFD))) ==
> -			      (XFS_PQUOTA_ACCT|XFS_OQUOTA_ENFD))
> -		xfs_qm_statvfs(ip, statp);

I thjink the correct fix here is to replace the || between the inode
flag and quota flag check with and && - we want both the above
conditions to be true.  Can you respin the patch by doing that and make
sure it still passes the test case?  I'd like to send it of to -stable
ASAP.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2012-04-11 19:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-01  4:55 [PATCH] xfs: don't fill statvfs with project quota for a directory if it was not enabled Jeff Liu
2012-04-02 16:39 ` Christoph Hellwig
2012-04-02 18:36   ` Chandra Seetharaman
2012-04-04  8:02   ` Jeff Liu
2012-04-04 16:48   ` Chandra Seetharaman
2012-04-05  5:16     ` Jeff Liu
2012-04-05  7:31       ` Jeff Liu
2012-04-11 19:59 ` Christoph Hellwig [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-12  3:59 sn0wing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120411195915.GA28816@infradead.org \
    --to=hch@infradead.org \
    --cc=bpm@sgi.com \
    --cc=jeff.liu@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox