From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mark Tinguely <tinguely@sgi.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: kill XBF_LOCK
Date: Thu, 12 Apr 2012 08:51:32 +1000 [thread overview]
Message-ID: <20120411225132.GV18323@dastard> (raw)
In-Reply-To: <20120411200729.GJ28816@infradead.org>
On Wed, Apr 11, 2012 at 04:07:29PM -0400, Christoph Hellwig wrote:
> On Wed, Apr 11, 2012 at 08:20:27AM +1000, Dave Chinner wrote:
> > > The reason I ask, the sources that I have for xfs_buf_get() seems to
> > > still have a "goto no_buffer" for the failed
> > > xfs_buf_allocate_memory() call and this patch removes that call. I
> > > did not find anything in the 8 buf clean-up series that would alter
> > > this area.
> >
> > I'm sure I posted it previously. Let me update all the reviewed-by
> > tags and I'll resend the entire series....
>
> I think Mark meant the patch to fix the error handling for failed
> allocation, which needs to be redone to only insert the buffer into the
> rbtree once it's fully set up.
Right. What I meant was that I need to resend the entire 12-13
buffer cache patches I have in my queue right now so that they
should all apply easily...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-04-11 22:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 10:03 [PATCH 0/3] xfs: More xfs_buf cleanups Dave Chinner
2012-04-10 10:03 ` [PATCH 1/3] xfs: kill XBF_LOCK Dave Chinner
2012-04-10 15:00 ` Mark Tinguely
2012-04-10 22:20 ` Dave Chinner
2012-04-11 20:07 ` Christoph Hellwig
2012-04-11 22:51 ` Dave Chinner [this message]
2012-04-11 22:59 ` Christoph Hellwig
2012-04-11 23:16 ` Dave Chinner
2012-04-12 13:23 ` Mark Tinguely
2012-04-11 20:05 ` Christoph Hellwig
2012-04-10 10:03 ` [PATCH 2/3] xfs: kill xfs_read_buf() Dave Chinner
2012-04-11 20:06 ` Christoph Hellwig
2012-04-10 10:03 ` [PATCH 3/3] xfs: kill XBF_DONTBLOCK Dave Chinner
2012-04-11 20:06 ` Christoph Hellwig
2012-04-11 20:08 ` [PATCH 0/3] xfs: More xfs_buf cleanups Christoph Hellwig
2012-04-13 12:02 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411225132.GV18323@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox