From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q3D9gVnd019122 for ; Fri, 13 Apr 2012 04:42:31 -0500 Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id O7y1gCxbIE6CNPUA for ; Fri, 13 Apr 2012 02:42:29 -0700 (PDT) Date: Fri, 13 Apr 2012 19:42:27 +1000 From: Dave Chinner Subject: Re: [PATCH 03/10] xfs: allow assigning the tail lsn with the AIL lock held Message-ID: <20120413094227.GG6734@dastard> References: <20120327164400.967415009@bombadil.infradead.org> <20120327164644.597749707@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120327164644.597749707@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Tue, Mar 27, 2012 at 12:44:03PM -0400, Christoph Hellwig wrote: > Provide a variant of xlog_assign_tail_lsn that has the AIL lock already > held. By doing so we do an additional atomic_read + atomic_set under > the lock, which comes down to two instructions. > > Switch xfs_trans_ail_update_bulk and xfs_trans_ail_delete_bulk to the > new version to reduce the number of lock roundtrips, and prepare for > a new addition that would require a third lock roundtrip in > xfs_trans_ail_delete_bulk. This addition is also the reason for > slightly rearranging the conditionals and relying on xfs_log_space_wake > for checking that the filesystem has been shut down internally. > > Signed-off-by: Christoph Hellwig Looks good, and will be slightly more efficient, too. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs