From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q3DAXjmx025731 for ; Fri, 13 Apr 2012 05:33:46 -0500 Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id lDkFTKMIqweIUYxX for ; Fri, 13 Apr 2012 03:33:44 -0700 (PDT) Date: Fri, 13 Apr 2012 20:33:38 +1000 From: Dave Chinner Subject: Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush Message-ID: <20120413103338.GK6734@dastard> References: <20120327164400.967415009@bombadil.infradead.org> <20120327164646.158577302@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120327164646.158577302@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Tue, Mar 27, 2012 at 12:44:07PM -0400, Christoph Hellwig wrote: > Instead of writing the buffer directly from inside xfs_qm_dqflush return it > to the caller and let the caller decide what to do with the buffer. Also > remove the pincount check in xfs_qm_dqflush that all non-blocking callers > already implement and the now unused flags parameter and the XFS_DQ_IS_DIRTY > check that all callers already perform. > > Signed-off-by: Christoph Hellwig Looks ok. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs