From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <elder@dreamhost.com>
Cc: xfs@oss.sgi.com
Subject: Re: BUG: task blocked on waiter in xfs_trans_dqlockedjoin()
Date: Tue, 17 Apr 2012 10:09:39 +1000 [thread overview]
Message-ID: <20120417000939.GB6734@dastard> (raw)
In-Reply-To: <4F8C1FDD.70600@dreamhost.com>
On Mon, Apr 16, 2012 at 08:34:21AM -0500, Alex Elder wrote:
> I am getting the following warning while running xfstests. I haven't
> started looking at it closely yet, but I wanted to report it so others
> could have a look. The XFS code in use was at commit c922bbc819,
Which does not modify locking at all.
> with ad637a10f4 cherry-picked on top of it. The tests all passed,
And that modifies the way we do inode reclaim synchronisation by
ILOCK rather than by IOLOCK|ILOCK. Neither of these are touching the
dquot locking at all, so I'm having trouble understanding why these
commits would cause a problem with a dquot mutex....
> so now I'm going to have to narrow down which test produces the failure
> (it was not near the first, nor the last test...).
>
> Here is the source of the warning:
> DEBUG_LOCKS_WARN_ON(ti->task->blocked_on != waiter);
That implies that the task is currently trying to acquire two
mutexes at once - which I can't see is possible. How different are
the two values i.e. are you seeing memory corruption?
Also, what case is the code running through? is it taking the
xfs_dqlock2() branch, and if so are the two dquots different?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-04-17 0:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 13:34 BUG: task blocked on waiter in xfs_trans_dqlockedjoin() Alex Elder
2012-04-16 20:41 ` Alex Elder
2012-04-17 0:09 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417000939.GB6734@dastard \
--to=david@fromorbit.com \
--cc=elder@dreamhost.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox