Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush

Dave Chinner
2012-04-13T10:33:46Z

On Tue, Mar 27, 2012 at 12:44:07PM -0400, Christoph Hellwig wrote:
> Instead of writing the buffer directly from inside xfs_qm_dqflush return it
> to the caller and let the caller decide what to do with the buffer. Also
> remove the pincount check in xfs_qm_dqflush that all non-blocking callers
> already implement and the now unused flags parameter and the XFS_DQ_IS_DIRTY
> check that all callers already perform.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks ok.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com