Re: [PATCH 08/10] xfs: do not add buffers to the delwri queue until pushed

Mark Tinguely
2012-04-18T21:11:32Z

On 03/27/12 11:44, Christoph Hellwig wrote:
> Instead of adding buffers to the delwri list as soon as they are logged,
> even if they can't be written until commited because they are pinned
> defer adding them to the delwri list until xfsaild pushes them. This
> makes the code more similar to other log items and prepares for writing
> buffers directly from xfsaild.
>
> The complication here is that we need to fail buffers that were added
> but not logged yet in xfs_buf_item_unpin, borrowing code from
> xfs_bioerror.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>

Looks good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>