From: Dave Chinner <david@fromorbit.com>
To: Tom Marek <tmarek@redhat.com>
Cc: lczerner@redhat.com, dchinner@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH 2/3 V2] xfstests 198, 240, common.rc: added check for aiodio-sparse2
Date: Thu, 19 Apr 2012 09:51:35 +1000 [thread overview]
Message-ID: <20120418235135.GS6734@dastard> (raw)
In-Reply-To: <1334654687-25450-2-git-send-email-tmarek@redhat.com>
On Tue, Apr 17, 2012 at 11:24:46AM +0200, Tom Marek wrote:
> Tests number 198 and 240 could fail when aiodio-sparse2 was not build.
> _require_aiodio helper was added to common.rc file to fix this.
>
> Cc: david@fromorbit.com
> Signed-off-by: Tom Marek <tmarek@redhat.com>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
.....
> @@ -770,6 +770,14 @@ _require_scratch()
> fi
> }
>
> +# this test needs aio-dio-regress to be built
> +#
> +_require_aiodio()
> +{
> + [ -x $here/src/aio-dio-regress/aiodio_sparse2 ] || \
> + _notrun "This tests requires src/aio-dio-regress/ to be built"
> +}
This function already exists in common.rc, which is why I pointed it
out for use.
# this test requires that a (specified) aio-dio executable exists
# $1 - command (optional)
#
_require_aiodio()
{
if [ -z "$1" ]
then
AIO_TEST=src/aio-dio-regress/aiodio_sparse2
[ -x $AIO_TEST ] || _notrun "aio-dio utilities required"
else
AIO_TEST=src/aio-dio-regress/$1
[ -x $AIO_TEST ] || _notrun "$AIO_TEST not built"
fi
}
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-04-18 23:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 9:24 [PATCH 1/3 V2] xfstests 233: fix user fsgqa access to fsstress Tom Marek
2012-04-17 9:24 ` [PATCH 2/3 V2] xfstests 198, 240, common.rc: added check for aiodio-sparse2 Tom Marek
2012-04-18 23:51 ` Dave Chinner [this message]
2012-04-19 8:32 ` Lukas Czerner
2012-04-19 13:53 ` Tom Marek
2012-04-17 9:24 ` [PATCH 3/3 V2] xfstests 273: fix of reading scratch size and removing lost+found Tom Marek
2012-04-19 0:01 ` [PATCH 1/3 V2] xfstests 233: fix user fsgqa access to fsstress Dave Chinner
2012-04-19 8:37 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418235135.GS6734@dastard \
--to=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=lczerner@redhat.com \
--cc=tmarek@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox