From: Dave Chinner <david@fromorbit.com>
To: Shaohua Li <shli@kernel.org>
Cc: hch@infradead.org, xfs@oss.sgi.com
Subject: Re: [RFC]xfs: using GFP_NOFS for blkdev_issue_flush
Date: Wed, 25 Apr 2012 10:25:52 +1000 [thread overview]
Message-ID: <20120425002552.GU9541@dastard> (raw)
In-Reply-To: <20120424132346.GA24575@kernel.org>
On Tue, Apr 24, 2012 at 09:23:46PM +0800, Shaohua Li wrote:
> On Wed, Apr 18, 2012 at 11:37:46AM +1000, Dave Chinner wrote:
> > On Mon, Apr 16, 2012 at 02:58:21PM +0800, Shaohua Li wrote:
> > > On 4/16/12 2:49 PM, Shaohua Li wrote:
> > > >
> > > >flush request is issued in transaction commit code path usually, so
> > > >looks using
> > > >GFP_KERNEL to allocate memory for flush request bio falls into the classic
> > > >deadlock issue (memory reclaim recursion). Use GFP_NOFS to avoid recursion
> > > >from reclaim context. Per Dave Chinner, there is only blkdev_issue_flush
> > > >might
> > > >be buggy here. But using GFP_NOFS by default for all calls should not
> > > >matter.
> >
> > Can you update the commit message like I suggested previously?
> Copied exactly.
>
>
> Issuing a block device flush request in transaction context using GFP_KERNEL
> directly can cause deadlocks due to memory reclaim recursion. Use GFP_NOFS to
> avoid recursion from reclaim context.
>
> Signed-off-by: Shaohua Li <shli@fusionio.com>
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/fs/xfs/xfs_super.c
> ===================================================================
> --- linux.orig/fs/xfs/xfs_super.c 2012-04-13 10:08:26.095496072 +0800
> +++ linux/fs/xfs/xfs_super.c 2012-04-13 10:08:42.555496865 +0800
> @@ -622,7 +622,7 @@ void
> xfs_blkdev_issue_flush(
> xfs_buftarg_t *buftarg)
> {
> - blkdev_issue_flush(buftarg->bt_bdev, GFP_KERNEL, NULL);
> + blkdev_issue_flush(buftarg->bt_bdev, GFP_NOFS, NULL);
> }
>
> STATIC void
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-04-25 0:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 6:49 [RFC]xfs: using GFP_NOFS for blkdev_issue_flush Shaohua Li
2012-04-16 6:58 ` Shaohua Li
2012-04-17 18:42 ` Mark Tinguely
2012-04-18 1:37 ` Dave Chinner
2012-04-24 13:23 ` Shaohua Li
2012-04-25 0:25 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425002552.GU9541@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=shli@kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox