From: "J. Bruce Fields" <bfields@fieldses.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: detecting case-insensitivity
Date: Thu, 3 May 2012 16:22:49 -0400 [thread overview]
Message-ID: <20120503202249.GB19237@fieldses.org> (raw)
In-Reply-To: <20120430230105.GL7015@dastard>
On Tue, May 01, 2012 at 09:01:05AM +1000, Dave Chinner wrote:
> On Mon, Apr 30, 2012 at 05:26:49PM -0400, J. Bruce Fields wrote:
> > On Wed, Apr 11, 2012 at 04:37:35PM -0400, J. Bruce Fields wrote:
> > > On Wed, Apr 11, 2012 at 04:03:35PM -0400, Christoph Hellwig wrote:
> > > > Can you add a new s_feature_flags instead of s_flags which is shared
> > > > with the mount user ABI? MS_I_VERSION should also move there.
> > >
> > > I was wondering about that. Yes, that makes a lot more sense, I'll work
> > > on it.
> >
> > Just something like this?
>
> .....
>
> > #define S_SYNC 1 /* Writes are synced at once */
> > @@ -268,7 +271,7 @@ struct inodes_stat_t {
> > ((inode)->i_flags & (S_SYNC|S_DIRSYNC)))
> > #define IS_MANDLOCK(inode) __IS_FLG(inode, MS_MANDLOCK)
> > #define IS_NOATIME(inode) __IS_FLG(inode, MS_RDONLY|MS_NOATIME)
> > -#define IS_I_VERSION(inode) __IS_FLG(inode, MS_I_VERSION)
> > +#define IS_I_VERSION(inode) ((inode)->i_sb->s_flags & SF_I_VERSION)
>
> (inode)->i_sb->s_feature_flags?
Whoops, thanks.
> > #define IS_NOQUOTA(inode) ((inode)->i_flags & S_NOQUOTA)
> > #define IS_APPEND(inode) ((inode)->i_flags & S_APPEND)
> > @@ -1428,7 +1431,8 @@ struct super_block {
> > const struct dquot_operations *dq_op;
> > const struct quotactl_ops *s_qcop;
> > const struct export_operations *s_export_op;
> > - unsigned long s_flags;
> > + unsigned long s_flags; /* mount flags */
> > + unsigned int s_feature_flags;
>
> why not an unsigned long like s_flags?
OK.
(Why does it matter? I figured we can always extend it later.)
--b.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-05-03 20:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-07 14:00 detecting case-insensitivity J. Bruce Fields
2012-04-08 23:02 ` Dave Chinner
2012-04-11 20:03 ` Christoph Hellwig
2012-04-11 20:37 ` J. Bruce Fields
2012-04-30 21:26 ` J. Bruce Fields
2012-04-30 23:01 ` Dave Chinner
2012-05-03 20:22 ` J. Bruce Fields [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-09 5:01 Vyacheslav Dubeyko
2012-04-09 21:28 ` J. Bruce Fields
2012-04-09 22:19 ` Dave Chinner
2012-04-09 22:27 ` J. Bruce Fields
2012-04-09 22:44 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503202249.GB19237@fieldses.org \
--to=bfields@fieldses.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox