From: Ben Myers <bpm@sgi.com>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/4] xfstests: Fix a problem where using bsize was not working as expected
Date: Fri, 4 May 2012 16:01:09 -0500 [thread overview]
Message-ID: <20120504210109.GX16881@sgi.com> (raw)
In-Reply-To: <20120221165839.23253.45298.sendpatchset@chandra-lucid.austin.ibm.com>
On Tue, Feb 21, 2012 at 10:58:39AM -0600, Chandra Seetharaman wrote:
> >From d60824ddc4a60c7902a53fded6773b3385180cc6 Mon Sep 17 00:00:00 2001
> From: Chandra Seetharaman <sekharan@us.ibm.com>
> Date: Wed, 8 Feb 2012 10:02:37 -0600
> Subject: [PATCH 1/3] Fix a problem wherein the bsize argument setting to mkfs fails to be
> included since MKFS_OPTIONS already has bsize.
>
> Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
> ---
> common.rc | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/common.rc b/common.rc
> index cab0b64..61889b0 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -350,7 +350,10 @@ _scratch_mkfs_sized()
>
> case $FSTYP in
> xfs)
> - _scratch_mkfs_xfs -d size=$fssize -b size=$blocksize
> + # replace bsize= in MKFS_OPTIONS if already defined
> + export MKFS_OPTIONS=$(echo $MKFS_OPTIONS | \
> + sed -e "s/-bsize=[0-9]*/-bsize=$blocksize/")
> + _scratch_mkfs_xfs "-d size=$fssize"
What if bsize wasn't specified already in MKFS_OPTIONS? It looks like you
wouldn't be passing in a blocksize.
-Ben
> ;;
> ext2|ext3|ext4|ext4dev)
> /sbin/mkfs.$FSTYP $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks
> --
> 1.7.1
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-05-04 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 16:58 [PATCH 0/4] xfstests: Test pquota and gquota being used together Chandra Seetharaman
2012-02-21 16:58 ` [PATCH 1/4] xfstests: Fix a problem where using bsize was not working as expected Chandra Seetharaman
2012-05-04 21:01 ` Ben Myers [this message]
2012-02-21 16:58 ` [PATCH 2/4] xfstests: Add a require_seppquota function Chandra Seetharaman
2012-05-04 21:26 ` Ben Myers
2012-02-21 16:58 ` [PATCH 3/4] xfstests: Add a simple test to check separate pquota/gquota Chandra Seetharaman
2012-02-21 16:58 ` [PATCH 4/4] xfstests: Add the new test to the group file Chandra Seetharaman
2012-05-04 21:07 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120504210109.GX16881@sgi.com \
--to=bpm@sgi.com \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox