Re: [PATCH 6/3] xfs: make largest supported offset less shouty

Ben Myers
2012-05-09T19:10:22Z

On Wed, May 09, 2012 at 08:43:30AM +1000, Dave Chinner wrote:
> On Tue, May 08, 2012 at 01:15:40PM -0500, Ben Myers wrote:
> > On Sun, Apr 29, 2012 at 10:57:29PM +1000, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
> > > XFS_MAXIOFFSET() is just a simple macro that resolves to
> > > mp->m_maxioffset. It doesn't need to exist, and it just makes the
> > > code unnecessarily loud and shouty.
> > >
> > > Make it quiet and easy to read.
> >
> > Yep, looks good.
> >
> > Reviewed-by: Ben Myers <bpm@sgi.com>
>
> I've got new versions that use s_maxbytes whih I need to post....

Ok, I'll hold off on this one.