From: Dave Chinner <david@fromorbit.com>
To: Zhu Han <schumi.han@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: fallocate bug?
Date: Tue, 8 May 2012 09:59:55 +1000 [thread overview]
Message-ID: <20120507235955.GE5091@dastard> (raw)
In-Reply-To: <CAF7KpS-r4zRXZxBU3U8ohxA85-rEvbAzCewYZDr44MNdP+YmFg@mail.gmail.com>
On Mon, May 07, 2012 at 08:44:17PM +0800, Zhu Han wrote:
> Seems like xfs of CentOS 6.X occupies much more storage space than desired
> if fallocate is used against the file. Here is the step to reproduce it:
You test case is not doing what you think it is doing.
> By the way, is it normal when the file is moved around after the
> preallocated region is filled with data?
>
> $ uname -r
> 2.6.32-220.7.1.el6.x86_64
>
> $fallocate -n --offset 0 -l 1G file ---->Write a little more data than
> the preallocated size
>
> $ xfs_bmap -p -vv file
> file:
> EXT: FILE-OFFSET BLOCK-RANGE AG AG-OFFSET
> TOTAL FLAGS
> 0: [0..2097151]: 2593408088..2595505239 21 (29420144..31517295)
> 2097152 10000
>
> $ dd if=/dev/zero of=/tmp/file bs=1M count=1026 conv=fsync
That does a truncate first, removing all the preallocated space. Use
conv=notrunc to avoid this. Hence the space allocated by this
new write is different to the space allocated by the above
preallocation. The file has not been moved, the filesystem just did
what you asked it to do.
>
> $ xfs_bmap -p -vv file
> file:
> EXT: FILE-OFFSET BLOCK-RANGE AG AG-OFFSET
> TOTAL FLAGS
> 0: [0..4194303]: 2709184016..2713378319 22 (23101408..27295711)
> 4194304 00000
And so now you've triggered the speculative delayed allocation
beyond EOF, which is normal behaviour. Hence there are currently
unused blocks beyond EOF which will get removed either when the next
close(fd) occurs on the file or the inode is removed from the cache.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-05-08 0:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 12:44 fallocate bug? Zhu Han
2012-05-07 23:59 ` Dave Chinner [this message]
2012-05-08 3:24 ` Zhu Han
2012-05-08 4:40 ` Dave Chinner
2012-05-08 5:10 ` Zhu Han
2012-05-08 5:47 ` Dave Chinner
2012-05-08 15:25 ` Zhu Han
2012-05-08 22:31 ` Dave Chinner
2012-05-09 1:43 ` Zhu Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507235955.GE5091@dastard \
--to=david@fromorbit.com \
--cc=schumi.han@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox