From: Ben Myers <bpm@sgi.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: jeff.liu@oracle.com, xfs@oss.sgi.com
Subject: Re: [PATCH] Introduce SEEK_DATA/SEEK_HOLE support v9
Date: Thu, 10 May 2012 15:08:32 -0500 [thread overview]
Message-ID: <20120510200832.GP16881@sgi.com> (raw)
In-Reply-To: <4FAC1C33.5050508@sgi.com>
On Thu, May 10, 2012 at 02:51:15PM -0500, Mark Tinguely wrote:
> On 05/10/12 08:29, Jeff Liu wrote:
> >Hello,
> >
> >This is the revised patch according to Mark's comments.
> >Is it possible to get it to accept if there are no other issues,
> >so that I can continue to work on the unwritten part based on that.
> >
> >Thanks,
> >-Jeff
> >
> >Signed-off-by: Jie Liu<jeff.liu@oracle.com>
> >
> >---
>
> >+
> >+STATIC loff_t
> >+xfs_seek_hole(
> >+ struct file *file,
> >+ loff_t start,
> >+ u32 type)
> >+{
> >+ struct inode *inode = file->f_mapping->host;
> >+ struct xfs_inode *ip = XFS_I(inode);
> >+ struct xfs_mount *mp = ip->i_mount;
> >+ loff_t uninitialized_var(offset);
> >+ loff_t holeoff;
> >+ xfs_fsize_t isize;
> >+ xfs_fileoff_t fsbno;
> >+ uint lock;
> >+ int error;
> >+
> >+ if (XFS_FORCED_SHUTDOWN(mp))
> >+ return -XFS_ERROR(EIO);
>
> I think xfs_bmapi_read() returns just a XFS_ERROR(EIO), not negative.
> Ben can fix up if you agree.
Looks like error is negated at the bottom of the function and is not a problem.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-05-10 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 13:29 [PATCH] Introduce SEEK_DATA/SEEK_HOLE support v9 Jeff Liu
2012-05-10 19:51 ` Mark Tinguely
2012-05-10 20:08 ` Ben Myers [this message]
2012-05-10 20:07 ` Mark Tinguely
2012-05-10 20:28 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510200832.GP16881@sgi.com \
--to=bpm@sgi.com \
--cc=jeff.liu@oracle.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox