public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC PATCH 2/3] xfs: fix xfsaild hang due to premature idle
Date: Mon, 21 May 2012 13:12:32 -0500	[thread overview]
Message-ID: <20120521181232.GS16099@sgi.com> (raw)
In-Reply-To: <1337620886-41807-3-git-send-email-bfoster@redhat.com>

Hey Brian,

On Mon, May 21, 2012 at 01:21:25PM -0400, Brian Foster wrote:
> Running xfstests 273 in a loop reproduces an XFS lockup due to
> xfsaild entering idle mode indefinitely. The following
> high-level sequence of events leads to the hang:
> 
> - xfsaild is running, hits the stuck item threshold and reschedules,
>   setting xa_last_pushed_lsn appropriately.
> - xa_threshold is updated.
> - xfsaild restarts from the previous xa_last_pushed_lsn, hits the
>   new target and enters idle mode, even though the previously
>   stuck items still populate the ail.
> 
> Modify the tout logic to only enter idle mode when the ail is empty.
> IOW, if we hit the target but did not perform the current scan from
> the start of the ail, reschedule at least one more time.
> 
> Signed-off-by: Brian Foster <bfoster@redhat.com>

Thanks for the patch.  Unfortunately it does not apply cleanly.  Care to spin it again?

Regards,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-05-21 18:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21 17:21 [RFC PATCH 0/3] xfs: fix xfsaild races and re-enable idle mode Brian Foster
2012-05-21 17:21 ` [RFC PATCH 1/3] xfs: re-enable xfsaild " Brian Foster
2012-05-21 17:21 ` [RFC PATCH 2/3] xfs: fix xfsaild hang due to premature idle Brian Foster
2012-05-21 18:12   ` Ben Myers [this message]
2012-05-21 18:15     ` Brian Foster
2012-05-21 17:21 ` [RFC PATCH 3/3] xfs: fix xfsaild hang due to lost wake ups Brian Foster
2012-05-22 23:15   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120521181232.GS16099@sgi.com \
    --to=bpm@sgi.com \
    --cc=bfoster@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox