From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: Brian Foster <bfoster@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: re-enable xfsaild idle mode and fix associated races
Date: Thu, 7 Jun 2012 12:13:53 +1000 [thread overview]
Message-ID: <20120607021353.GR22848@dastard> (raw)
In-Reply-To: <4FCCEF94.7020501@sgi.com>
On Mon, Jun 04, 2012 at 12:25:40PM -0500, Mark Tinguely wrote:
> On 05/24/12 11:06, Brian Foster wrote:
> >xfsaild idle mode logic currently leads to a couple hangs:
> >
> >1.) If xfsaild is rescheduled in during an incremental scan
> > (i.e., tout != 0) and the target has been updated since
> > the previous run, we can hit the new target and go into
> > idle mode with a still populated ail.
> >2.) A wake up is only issued when the target is pushed forward.
> > The wake up can race with xfsaild if it is currently in the
> > process of entering idle mode, causing future wake up
> > events to be lost.
> >
> >Both hangs are reproducible by running xfstests 273 in a loop.
> >Modify xfsaild to enter idle mode only when the ail is empty
> >and the push target has not been moved forward since the last
> >push.
> >
> >Signed-off-by: Brian Foster<bfoster@redhat.com>
> >---
>
> I wouldn't mind keeping an large (a few minutes) wake up value for the
> empty AIL case to be paranoid.
And then we'll never hear about hangs....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-06-07 2:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 16:06 [PATCH] xfs: re-enable xfsaild idle mode and fix associated races Brian Foster
2012-06-04 14:39 ` Brian Foster
2012-06-04 17:25 ` Mark Tinguely
2012-06-07 2:13 ` Dave Chinner [this message]
2012-06-07 2:24 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607021353.GR22848@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox