From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q58Jc7h2249917 for ; Fri, 8 Jun 2012 14:38:08 -0500 Date: Fri, 8 Jun 2012 14:44:50 -0500 From: Ben Myers Subject: Re: [PATCH] xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent() Message-ID: <20120608194450.GP4721@sgi.com> References: <4FD2535A.3050302@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4FD2535A.3050302@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs-oss On Fri, Jun 08, 2012 at 02:32:42PM -0500, Eric Sandeen wrote: > w/o this change I was getting: > > [ 742.376495] ODEBUG: object is on stack, but not annotated > [ 742.377007] ------------[ cut here ]------------ > [ 742.377007] WARNING: at lib/debugobjects.c:302 __debug_object_init+0x1c0/0x3d0() > ... > [ 742.377007] Call Trace: > [ 742.377007] [] warn_slowpath_common+0x7f/0xc0 > [ 742.377007] [] warn_slowpath_null+0x1a/0x20 > [ 742.377007] [] __debug_object_init+0x1c0/0x3d0 > [ 742.377007] [] debug_object_init+0x1f/0x30 > [ 742.377007] [] __init_work+0x19/0x30 > [ 742.377007] [] xfs_alloc_vextent+0x101/0x190 [xfs] > > on a debug 3.4 kernel. > > Signed-off-by: Eric Sandeen Looks pretty good. ;) Reviewed-by: Ben Myers _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs