From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q5FCd7Ds090424 for ; Fri, 15 Jun 2012 07:39:07 -0500 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id oLHqNesA0VOHoWuJ (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 15 Jun 2012 05:39:06 -0700 (PDT) Date: Fri, 15 Jun 2012 08:39:05 -0400 From: Christoph Hellwig Subject: Re: [PATCH] xfs: fix allocbt cursor leak in xfs_alloc_ag_vextent_near Message-ID: <20120615123905.GB8151@infradead.org> References: <1339474826-10414-1-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1339474826-10414-1-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Tue, Jun 12, 2012 at 02:20:26PM +1000, Dave Chinner wrote: > From: Dave Chinner > > When we fail to find an matching extent near the requested extent > specification during a left-right distance search in > xfs_alloc_ag_vextent_near, we fail to free the original cursor that > we used to look up the XFS_BTNUM_CNT tree and hence leak it. > > Reported-by: Chris J Arges > Signed-off-by: Dave Chinner Looks correct for now, but mid-term this function absolutely needs a restructuring with good exit labels and a posisble a split up into multiple helpers. Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs