From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q5I3OWMc118730 for ; Sun, 17 Jun 2012 22:24:32 -0500 Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id VPUefDgntGOwa0ZL for ; Sun, 17 Jun 2012 20:24:30 -0700 (PDT) Resent-Message-ID: <20120618032428.GP19223@dastard> Resent-To: Christoph Hellwig , xfs@oss.sgi.com Date: Mon, 18 Jun 2012 11:46:54 +1000 From: Dave Chinner Subject: Re: [PATCH 2/7] xfs: split xfs_dialloc Message-ID: <20120618014654.GI19223@dastard> References: <20120605144647.051012936@bombadil.infradead.org> <20120605144835.679206152@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120605144835.679206152@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Tue, Jun 05, 2012 at 10:46:49AM -0400, Christoph Hellwig wrote: > Move the actual allocation once we have selected an allocation group into a > separate helper, and make xfs_dialloc a wrapper around it. > > Signed-off-by: Christoph Hellwig looks ok. One minor thing - convert all the typedefs in the in xfs_dialloc() function header to struct xxx format while you are touching this code... Other than that, Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs