From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q5I3Q5P1118875 for ; Sun, 17 Jun 2012 22:26:05 -0500 Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id QDyERVxlcNqnBtEo for ; Sun, 17 Jun 2012 20:26:04 -0700 (PDT) Resent-Message-ID: <20120618032602.GQ19223@dastard> Resent-To: Christoph Hellwig , xfs@oss.sgi.com Date: Mon, 18 Jun 2012 12:07:27 +1000 From: Dave Chinner Subject: Re: [PATCH 3/7] xfs: remove the alloc_done argument to xfs_dialloc Message-ID: <20120618020727.GJ19223@dastard> References: <20120605144647.051012936@bombadil.infradead.org> <20120605144835.887274634@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120605144835.887274634@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Tue, Jun 05, 2012 at 10:46:50AM -0400, Christoph Hellwig wrote: > We can simplify check the IO_agbp pointer for being non-NULL instead of > passing another argument through two layers of function calls. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs