Re: [PATCH 5/9] xfs: struct xfs_buf_log_format isn't variable sized.

Christoph Hellwig
2012-06-20T07:05:48Z

On Wed, Jun 20, 2012 at 05:01:47PM +1000, Dave Chinner wrote:
> On Wed, Jun 20, 2012 at 02:36:12AM -0400, Christoph Hellwig wrote:
> > I like this patch with two minor nitpicks below. Given that it's a mostly
> > unrelated cleanup I'd also propagate it to the first patch in the
> > series.
>
> it's not unrelated - it makes the multiple buffer support so much
> easier to implement it's not funny....

Well, not entirely unrelated, but defintively a separate cleanup that
helpers later on. I usually try to have these first in the series.

> XFS_MAX_BLOCKSIZE is now needed xfs_buf_item.h, so rather than
> introduce a dependency on xfs_alloc_btree.h, I moved them to where
> the other limits are defined (i.e. xfs_types.h).

Ok. Please add a short blurb on this to the commit message.