Re: [PATCH] xfs: shutdown xfs_sync_worker before the log

Mark Tinguely
2012-05-31T16:23:28Z

On 05/25/12 15:45, Ben Myers wrote:

> xfs: shutdown xfs_sync_worker before the log
>
> Revert commit 1307bbd, which uses the s_umount semaphore to provide
> exclusion between xfs_sync_worker and unmount, in favor of shutting down
> the sync worker before freeing the log in xfs_log_unmount. This is a
> cleaner way of resolving the race between xfs_sync_worker and unmount
> than using s_umount.
>
> Index: xfs/fs/xfs/xfs_log.c

Waiting for the worker to end before destroying the AIL looks like a
better solution.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>