Re: [PATCH] xfs: shutdown xfs_sync_worker before the log

Brian Foster
2012-05-29T15:37:01Z

On 05/29/2012 11:07 AM, Ben Myers wrote:
> On Fri, May 25, 2012 at 03:45:36PM -0500, Ben Myers wrote:
>> On Thu, May 24, 2012 at 05:39:52PM -0500, Ben Myers wrote:
>>> Anyway, I'll make some time to work on this tomorrow so I can test it over
>>> the weekend.
>>
>> This is going to spin over the weekend. See what you think.
>
> I'm reasonably satisfied with the test results over the weekend. I did end up
> hitting an unrelated assert:
>

I started testing the xfsaild idle patch based against the xfs tree over
the weekend (after testing successfully against Linus' tree for several
days) and reproduced the xfs_sync_worker() hang that Mark alerted me to
last week. I was considering doing a bisect in that tree since it
doesn't occur in Linus' tree, but it sounds like I can pull this patch
now and shouldn't expect to reproduce the sync_worker() hang either,
correct? Thanks.

Brian

> [137111.090394] XFS: Assertion failed: (iflags & BMV_IF_DELALLOC) != 0, file: /root/xfs/fs/xfs/xfs_bmap.c, line: 5635
>
> Signed-off-by: Ben Myers <bpm@sgi.com>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs