public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: bpm@sgi.com, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Jan Engelhardt <jengelh@inai.de>,
	joe@perches.com, xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] types.h: implement intptr_t and uintptr_t
Date: Thu, 21 Jun 2012 03:13:19 -0400	[thread overview]
Message-ID: <20120621071319.GC5106@infradead.org> (raw)
In-Reply-To: <20120620230232.GN30705@dastard>

On Thu, Jun 21, 2012 at 09:02:32AM +1000, Dave Chinner wrote:
> On Wed, Jun 20, 2012 at 03:52:16AM -0400, Christoph Hellwig wrote:
> > I'd really like to get Jans type cleanups in XFS in for the next
> > merge window.  Given the lack of feedback on lkml in favor or
> > against (u)intptr_t I'm tempted to add them to xfs_linux.h for now,
> > and then do another push to propagate them to kernel-wide types later.
> > 
> > Is that fine with everybody?
> 
> I'd just push it into the XFS tree and into linux-next. It's a
> relatively harmless set of changes, and if nobody cares enough about
> it except us, just push it and see what happens when people start
> noticing the conflicts it might cause....

Given that's it's been out on lkml for a while that sounds at least
okay-ish.  I just fear we might get dragged into a long discussion when
then pull request is sent.  Just adding the types locally and moving
them to types.h in a single patch avoids that.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-06-21  7:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-31 18:05 [PATCH 1/2] types.h: implement intptr_t and uintptr_t Jan Engelhardt
2012-05-31 18:05 ` [PATCH 2/2] xfs: use standard (u)intptr_t types Jan Engelhardt
2012-06-20  7:52 ` [PATCH 1/2] types.h: implement intptr_t and uintptr_t Christoph Hellwig
2012-06-20 16:36   ` Ben Myers
2012-06-20 23:02   ` Dave Chinner
2012-06-21  7:13     ` Christoph Hellwig [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-05-25 10:37 [PATCH 4/6] build: use standard type intptr_t Christoph Hellwig
2012-05-25 15:52 ` xfsprogs/build: " Jan Engelhardt
2012-05-25 15:52   ` [PATCH 1/2] types.h: implement intptr_t and uintptr_t Jan Engelhardt
2012-05-31 17:59     ` Ben Myers
2012-05-31 18:05       ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120621071319.GC5106@infradead.org \
    --to=hch@infradead.org \
    --cc=bpm@sgi.com \
    --cc=david@fromorbit.com \
    --cc=jengelh@inai.de \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox