From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [regression] stack overflow in xfs_buf_iodone_callbacks
Date: Fri, 22 Jun 2012 09:24:14 +1000 [thread overview]
Message-ID: <20120621232414.GD10673@dastard> (raw)
In-Reply-To: <20120621163409.GA7897@infradead.org>
On Thu, Jun 21, 2012 at 12:34:09PM -0400, Christoph Hellwig wrote:
> On Thu, Jun 21, 2012 at 07:18:03PM +1000, Dave Chinner wrote:
> > Folks,
> >
> > I just had a stack overflow in the delayed write buffer error
> > handling with a shut down filesystem:
>
> I've looked at this a bit more, and it seems the effect really can't
> be an XFS shutdown. We never do the shutdown check inside
> xfs_buf_iorequest. The issue obviously is real, but could it be that
> you had an actual persistent I/O error on the underlying device?
It may have been - I didn't catch the initial cause of the problem
in my log because it hard-hung the VM and it wasn't in the
scrollback buffer on the console. All I saw was a corruption error,
a shutdown and the stack blowing up.
Still, I think there is a real problem here - any persistent device
error on IO submission can cause this problem to occur....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-06-21 23:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 9:18 [regression] stack overflow in xfs_buf_iodone_callbacks Dave Chinner
2012-06-21 9:21 ` Christoph Hellwig
2012-06-21 9:29 ` Dave Chinner
2012-06-21 10:06 ` Stan Hoeppner
2012-06-21 16:34 ` Christoph Hellwig
2012-06-21 23:24 ` Dave Chinner [this message]
2012-06-22 16:41 ` Christoph Hellwig
2012-06-22 23:39 ` Dave Chinner
2012-06-25 9:06 ` Christoph Hellwig
2012-06-26 2:20 ` Dave Chinner
2012-06-26 7:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621232414.GD10673@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox