From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q5LNOLtY164293 for ; Thu, 21 Jun 2012 18:24:21 -0500 Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id jKTI9s113D8IWQ4G for ; Thu, 21 Jun 2012 16:24:18 -0700 (PDT) Date: Fri, 22 Jun 2012 09:24:14 +1000 From: Dave Chinner Subject: Re: [regression] stack overflow in xfs_buf_iodone_callbacks Message-ID: <20120621232414.GD10673@dastard> References: <20120621091803.GB10673@dastard> <20120621163409.GA7897@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120621163409.GA7897@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Thu, Jun 21, 2012 at 12:34:09PM -0400, Christoph Hellwig wrote: > On Thu, Jun 21, 2012 at 07:18:03PM +1000, Dave Chinner wrote: > > Folks, > > > > I just had a stack overflow in the delayed write buffer error > > handling with a shut down filesystem: > > I've looked at this a bit more, and it seems the effect really can't > be an XFS shutdown. We never do the shutdown check inside > xfs_buf_iorequest. The issue obviously is real, but could it be that > you had an actual persistent I/O error on the underlying device? It may have been - I didn't catch the initial cause of the problem in my log because it hard-hung the VM and it wasn't in the scrollback buffer on the console. All I saw was a corruption error, a shutdown and the stack blowing up. Still, I think there is a real problem here - any persistent device error on IO submission can cause this problem to occur.... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs