From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [regression] stack overflow in xfs_buf_iodone_callbacks
Date: Tue, 26 Jun 2012 03:51:47 -0400 [thread overview]
Message-ID: <20120626075147.GA22780@infradead.org> (raw)
In-Reply-To: <20120626022011.GB19223@dastard>
On Tue, Jun 26, 2012 at 12:20:11PM +1000, Dave Chinner wrote:
> We will very soon - CRC checks after reading for disk will be done
> after reads. The patch series I'm working on at the moment
> introduces sanity checks of buffers on read completion - it doesn't
> do CRC checks yet, but it moves all the checks we do on read
> completion into iodone callbacks, and when CRCs are introduced they
> will simply be slotted into those functions....
I'm tempted to move calling of b_iodone into the caller that gets
waken by the completion, as that would help to clean a lot of nasty
bits up, but that's still a bit out.
The whole area aound xfs_bdstrat_cb, xfsbdstrat and buffer error handling
is something that needs a fair amount of attention, and I plan to tackle
a lot of it for 3.6.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-06-26 7:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 9:18 [regression] stack overflow in xfs_buf_iodone_callbacks Dave Chinner
2012-06-21 9:21 ` Christoph Hellwig
2012-06-21 9:29 ` Dave Chinner
2012-06-21 10:06 ` Stan Hoeppner
2012-06-21 16:34 ` Christoph Hellwig
2012-06-21 23:24 ` Dave Chinner
2012-06-22 16:41 ` Christoph Hellwig
2012-06-22 23:39 ` Dave Chinner
2012-06-25 9:06 ` Christoph Hellwig
2012-06-26 2:20 ` Dave Chinner
2012-06-26 7:51 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626075147.GA22780@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox