From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/9] xfs: separate buffer indexing from block map
Date: Tue, 26 Jun 2012 06:14:42 -0400 [thread overview]
Message-ID: <20120626101442.GB26241@infradead.org> (raw)
In-Reply-To: <1340355015-26250-3-git-send-email-david@fromorbit.com>
On Fri, Jun 22, 2012 at 06:50:08PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> To support discontiguous buffers in the buffer cache, we need to
> separate the cache index variables from the I/O map. While this is
> currently a 1:1 mapping, discontiguous buffer support will break
> this relationship.
>
> However, for caching purposes, we can still treat them the same as a
> contiguous buffer - the block number of the first block and the
> length of the buffer - as that is still a unique representation.
> Also, the only way we will ever access the discontiguous regions of
> buffers is via bulding the complete buffer in the first place, so
> using the initial block number and entire buffer length is a sane
> way to index the buffers.
>
> Add a block mapping vector construct to the xfs_buf and use it in
> the places where we are doing IO instead of the current
> b_bn/b_length variables.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-06-26 10:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 8:50 [PATCH 0/9, V2] xfs; discontiguous buffer support Dave Chinner
2012-06-22 8:50 ` [PATCH 1/9] xfs: struct xfs_buf_log_format isn't variable sized Dave Chinner
2012-06-26 10:14 ` Christoph Hellwig
2012-06-22 8:50 ` [PATCH 2/9] xfs: separate buffer indexing from block map Dave Chinner
2012-06-26 10:14 ` Christoph Hellwig [this message]
2012-06-22 8:50 ` [PATCH 3/9] xfs: convert internal buffer functions to pass maps Dave Chinner
2012-06-26 10:15 ` Christoph Hellwig
2012-06-22 8:50 ` [PATCH 4/9] xfs: add discontiguous buffer map interface Dave Chinner
2012-06-22 8:50 ` [PATCH 5/9] xfs: add discontiguous buffer support to transactions Dave Chinner
2012-06-22 8:50 ` [PATCH 6/9] xfs: support discontiguous buffers in the xfs_buf_log_item Dave Chinner
2012-06-22 8:50 ` [PATCH 7/9] xfs: use discontiguous xfs_buf support in dabuf wrappers Dave Chinner
2012-06-22 8:50 ` [PATCH 8/9] xfs: remove struct xfs_dabuf and infrastructure Dave Chinner
2012-06-22 8:50 ` [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents Dave Chinner
2012-06-26 10:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626101442.GB26241@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox