From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q5QAGirx086257 for ; Tue, 26 Jun 2012 05:16:44 -0500 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id uwxKyUUolhCaEd95 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Tue, 26 Jun 2012 03:16:44 -0700 (PDT) Date: Tue, 26 Jun 2012 06:16:43 -0400 From: Christoph Hellwig Subject: Re: [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents Message-ID: <20120626101643.GD26241@infradead.org> References: <1340355015-26250-1-git-send-email-david@fromorbit.com> <1340355015-26250-10-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1340355015-26250-10-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Fri, Jun 22, 2012 at 06:50:15PM +1000, Dave Chinner wrote: > From: Dave Chinner > > The buffer reading code in xfs_dir2_leaf_getdents is complex and difficult to > follow due to the readahead and all the context is carries. it is also badly > indented and so difficult to read. Factor it out into a separate function to > make it easier to understand and optimise in future patches. > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs