From: Carlos Maiolino <cmaiolino@redhat.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: synchronously write the superblock on unmount
Date: Tue, 26 Jun 2012 15:09:02 -0300 [thread overview]
Message-ID: <20120626180902.GA8842@andromeda.usersys.redhat.com> (raw)
In-Reply-To: <20120626160102.898671754@sgi.com>
Hi,
comments inlined below
> @@ -1571,19 +1569,16 @@ xfs_log_sbcount(xfs_mount_t *mp)
> * counters on every modification.
> */
> if (!xfs_sb_version_haslazysbcount(&mp->m_sb))
> - return 0;
> + return 0;
^^^
I'd like to point this cosmetic thing about properly alignment of the
statement with its parent if condition.
>
> ===================================================================
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -371,7 +371,9 @@ typedef struct xfs_mod_sb {
> int64_t msb_delta; /* Change to make to specified field */
> } xfs_mod_sb_t;
>
> -extern int xfs_log_sbcount(xfs_mount_t *);
> +extern int
> +xfs_write_sbcount(
> + struct xfs_mount *mp);
I would also write it in one single line, but this is just my point of view
Otherwise, looks good
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
--
--Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-06-26 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120626160051.364635296@sgi.com>
2012-06-26 16:00 ` [PATCH] xfs: synchronously write the superblock on unmount tinguely
2012-06-26 18:09 ` Carlos Maiolino [this message]
2012-06-26 21:06 ` Christoph Hellwig
2012-06-27 10:08 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626180902.GA8842@andromeda.usersys.redhat.com \
--to=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox