From: Christoph Hellwig <hch@infradead.org>
To: tinguely@sgi.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: synchronously write the superblock on unmount
Date: Tue, 26 Jun 2012 17:06:55 -0400 [thread overview]
Message-ID: <20120626210655.GA16140@infradead.org> (raw)
In-Reply-To: <20120626160102.898671754@sgi.com>
> /*
> - * xfs_log_sbcount
> + * xfs_write_sbcount
Please drop these function name comment line in anything you touch.
> *
> * Sync the superblock counters to disk.
> *
> - * Note this code can be called during the process of freezing, so
> - * we may need to use the transaction allocator which does not
> - * block when the transaction subsystem is in its frozen state.
> */
Can you add a little commt here on why we write it out synchronously?
Basically a shortened version of the commit message.
> if (!xfs_sb_version_haslazysbcount(&mp->m_sb))
> - return 0;
> + return 0;
As mentioned by carlos the indendation here got messed up a bit.
> -extern int xfs_log_sbcount(xfs_mount_t *);
> +extern int
> +xfs_write_sbcount(
> + struct xfs_mount *mp);
> extern __uint64_t xfs_default_resblks(xfs_mount_t *mp);
For the header I'd suggest to keep the simple indentation style.
Otherwise the changes look good to, thanks a lot!
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-06-26 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120626160051.364635296@sgi.com>
2012-06-26 16:00 ` [PATCH] xfs: synchronously write the superblock on unmount tinguely
2012-06-26 18:09 ` Carlos Maiolino
2012-06-26 21:06 ` Christoph Hellwig [this message]
2012-06-27 10:08 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626210655.GA16140@infradead.org \
--to=hch@infradead.org \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox