public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: cleanup the mount options
Date: Thu, 28 Jun 2012 11:01:56 -0500	[thread overview]
Message-ID: <20120628160156.GC29979@sgi.com> (raw)
In-Reply-To: <4FEBAB3B.6020707@cn.fujitsu.com>

Hey Wanlong,

On Thu, Jun 28, 2012 at 08:54:19AM +0800, Wanlong Gao wrote:
> On 06/28/2012 01:44 AM, Christoph Hellwig wrote:
> > On Thu, Jun 28, 2012 at 12:57:23AM +0800, Wanlong Gao wrote:
> >> remove the mount options macro, use tokens instead.
> >> Futher cleanup will use xfs_*_opt in xfs instead,
> >> but it may be hard to be merged in one patch.
> > 
> > Thanks a lot!
> > 
> > I like the use of the option parse a lot, this has been long overdue.
> > 
> > But is there any good reason to add the xfs_*_opt macros?  They make
> > reading and especially grepping the code a lot harder, so there better
> > be a good reason for them.
> 
> I think that using the macro makes code more clearly, and it's more
> convenient to use the macro than the original "|=", "&=" and "&" things.
> And, no more harder for reading and grepping, just omit the "XFS_MOUNT_".

Granted.  It's not hard to omit 'XFS_MOUNT_'.  The difficulty is that when you
omit XFS_MOUNT_ in your grep, you may get many more unrelated hits from other
contexts to sift through.  Maybe that's what Christoph was getting at.

> BTW, these macros were borrowed from Btrfs. I myself like it, but if
> you XFS guys all do not like, I can drop it.

It's not a strong objection from me, but I do have a preference for keeping the
XFS_MOUNT_ prefix to retain context for cscope and grep.  Maybe others feel
differently.

Regards,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-06-28 15:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-27 16:57 [PATCH] xfs: cleanup the mount options Wanlong Gao
2012-06-27 17:44 ` Christoph Hellwig
2012-06-28  0:54   ` Wanlong Gao
2012-06-28 16:01     ` Ben Myers [this message]
2012-06-28 16:33       ` Zach Brown
2012-06-28 19:54         ` Carlos Maiolino
2012-06-29  1:00         ` Wanlong Gao
2012-06-29 16:29           ` Zach Brown
2012-06-29 16:37             ` Wanlong Gao
2012-06-29 18:06 ` [PATCH 1/2 V2] " Wanlong Gao
2012-06-29 18:06   ` [PATCH 2/2] xfs: rename xfs_fs_* to xfs_* Wanlong Gao
2012-07-01 23:47     ` Dave Chinner
2012-07-02  0:39       ` Wanlong Gao
2012-07-02  6:26   ` [PATCH 1/2 V2] xfs: cleanup the mount options Christoph Hellwig
2012-07-02  7:05     ` [PATCH V3] " Wanlong Gao
2012-07-06  3:05       ` Dave Chinner
2012-07-08 11:36         ` [PATCH V4] " Wanlong Gao
2012-07-09  0:22           ` Dave Chinner
2012-07-09  9:21             ` Wanlong Gao
2012-07-11  2:26               ` Dave Chinner
2012-07-11  6:29                 ` [PATCH V5] " Wanlong Gao
2012-07-16  8:06                   ` Wanlong Gao
2012-07-23 20:33                     ` Ben Myers
2012-07-23 23:28                   ` Dave Chinner
2012-07-24  2:01                     ` Wanlong Gao
2012-07-24 21:18                       ` Dave Chinner
2012-07-25  1:09                         ` Wanlong Gao
2012-07-25  1:11                         ` [PATCH V7] " Wanlong Gao
2012-07-29 22:09                           ` Dave Chinner
2012-08-28 19:38                           ` Ben Myers
2012-07-24  2:10                     ` [PATCH V6] " Wanlong Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120628160156.GC29979@sgi.com \
    --to=bpm@sgi.com \
    --cc=gaowanlong@cn.fujitsu.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox