From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks
Date: Wed, 4 Jul 2012 01:57:23 -0400 [thread overview]
Message-ID: <20120704055723.GB27500@infradead.org> (raw)
In-Reply-To: <20120703232923.GC19223@dastard>
On Wed, Jul 04, 2012 at 09:29:23AM +1000, Dave Chinner wrote:
> It's not working yet - I found an issue with logging and writeback
> of uncached buffers through the AIL (i.e. the superblock). This only
> works by good fortune right now and requires uncached buffers to
> carry their block number internally, so I need to rethink and rework
> the patch.
What is the problem with uncached buffers? I'd hate having to move
the superblock buffer away from the uncached scheme.
> How much does it change? I'm also trying to get all the read verify
> callback infrastructure changes done for 3.6, and i suspect these may
> step on each other. I've just about got those patches done - testing
> and bug fixing is happening at the moment....
Basically a lot of impact around all callers of xfsbdstrat (which is
going away) and some impact in xfs_buf.c around the higher-level
read/write code. I'm not entirely done with the plane I have so
other things might get in the way and make it more complicated in
the end.
Another thing it depends on is to only start the sync work item later
during mount so that the re-read of the superblock after recovery can
use normal buffer cache interfaces instead of xfsbdstrat. I have a
minimal version of that in my tree but was waiting for your planned
large changes in that area.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-07-04 5:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 10:00 [PATCH 0/2] buffer caches fixes for Linux 3.5 Christoph Hellwig
2012-07-02 10:00 ` [PATCH 1/2] xfs: prevent recursion in xfs_buf_iorequest Christoph Hellwig
2012-07-03 0:27 ` Dave Chinner
2012-07-02 10:00 ` [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks Christoph Hellwig
2012-07-03 0:28 ` Dave Chinner
2012-07-03 16:05 ` Christoph Hellwig
2012-07-03 23:29 ` Dave Chinner
2012-07-04 5:57 ` Christoph Hellwig [this message]
2012-07-04 8:32 ` Dave Chinner
2012-07-04 15:16 ` Christoph Hellwig
2012-07-12 23:04 ` Ben Myers
2012-07-13 6:16 ` Christoph Hellwig
2012-07-13 6:24 ` [PATCH 2/2 v2] " Christoph Hellwig
2012-07-13 16:59 ` Ben Myers
2012-07-13 19:12 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120704055723.GB27500@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox