public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christian Kujau <lists@nerdbynature.de>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: 3.5.0-rc5: inconsistent lock state
Date: Fri, 6 Jul 2012 07:59:40 +1000	[thread overview]
Message-ID: <20120705215940.GP19223@dastard> (raw)
In-Reply-To: <alpine.DEB.2.01.1207050535420.5568@trent.utfs.org>

On Thu, Jul 05, 2012 at 05:44:50AM -0700, Christian Kujau wrote:
> On Thu, 5 Jul 2012 at 03:43, Christoph Hellwig wrote:
> > See my "do not take the iolock in inode reclaim context" series from
> > yesterday, which should take care of this.
> 
> OK, good. I'll wait until this hits mainline then.
> 
> > Btw, if you hit this it's a sign you have out of the inode attributes,
> > so if this isn't just a single inode with them you might be better off
> > using larger inodes.
> 
> ..."(run) out of inode attributes" - not really sure what that means and 
> why that would be the case.

It means that you have enough attributes that they don't fit in the
inode, so every time they are read or written you have to do an
extra IO on top of reading/writing the inode. Performance can easily
drop by an order of magnitude when the attributes are moved out of
the inode....

Typically there is 50-70 bytes of attribute space available in 256
byte inodes, larger attributes or lots of them will push them out of
the inode....

> And "using larger inodes" sounds like a 
> reformat with a larger "-i size=" option.

Yes, inode size is defined at mkfs time.

> Is there a way to find out my 
> current inode size? "mkfs.xfs -N" does not print its default values on a 
> mounted filesystem and I'm pretty sure I've used the default values when I 
> created the filesystem a while ago (i.e. just plain "mkfs.xfs" w/o any 
> options)

xfs_info <mntpt>

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-07-05 21:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-04 19:13 3.5.0-rc5: inconsistent lock state Christian Kujau
2012-07-04 19:14 ` Christian Kujau
2012-07-05  7:43 ` Christoph Hellwig
2012-07-05 12:44   ` Christian Kujau
2012-07-05 21:59     ` Dave Chinner [this message]
2012-07-05 23:39       ` Christian Kujau
2012-07-06  1:01         ` Dave Chinner
2012-07-06  1:55           ` Christian Kujau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120705215940.GP19223@dastard \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=lists@nerdbynature.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox