From: Dave Chinner <david@fromorbit.com>
To: Brad Arrington <bradla8@yahoo.com>
Cc: Ben Myers <bpm@sgi.com>, Alex Elder <elder@kernel.org>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 1/1] ACL: increase the #define XFS_ACL_MAX_ENTRIES to 128 The xfsprogs xfs_repair will have to be increased also if this is okay.
Date: Fri, 6 Jul 2012 08:08:32 +1000 [thread overview]
Message-ID: <20120705220832.GQ19223@dastard> (raw)
In-Reply-To: <1341520391-9704-1-git-send-email-bradla8@yahoo.com>
On Thu, Jul 05, 2012 at 01:33:11PM -0700, Brad Arrington wrote:
>
> Signed-off-by: Brad Arrington <bradla8@yahoo.com>
> ---
> fs/xfs/xfs_acl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_acl.h b/fs/xfs/xfs_acl.h
> index 39632d9..716d4d2 100644
> --- a/fs/xfs/xfs_acl.h
> +++ b/fs/xfs/xfs_acl.h
> @@ -22,7 +22,7 @@ struct inode;
> struct posix_acl;
> struct xfs_inode;
>
> -#define XFS_ACL_MAX_ENTRIES 25
> +#define XFS_ACL_MAX_ENTRIES 128
That's an on disk format change - you can't just increase it like
that without some kind of superblock feature bit to indicate that
the limit is 128 rather than 25 on that filesystem.
As it is, if we are going to change it, it will get changed to allow
the maximum number of ACLs an attribute can hold, not another
arbitrary number like 128....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
parent reply other threads:[~2012-07-05 22:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1341520391-9704-1-git-send-email-bradla8@yahoo.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120705220832.GQ19223@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=bradla8@yahoo.com \
--cc=elder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox