Re: [PATCH] xfs: cleanup the mount options

Christoph Hellwig
2012-06-27T17:44:53Z

On Thu, Jun 28, 2012 at 12:57:23AM +0800, Wanlong Gao wrote:
> remove the mount options macro, use tokens instead.
> Futher cleanup will use xfs_*_opt in xfs instead,
> but it may be hard to be merged in one patch.

Thanks a lot!

I like the use of the option parse a lot, this has been long overdue.

But is there any good reason to add the xfs_*_opt macros? They make
reading and especially grepping the code a lot harder, so there better
be a good reason for them.