Re: [PATCH V7] xfs: cleanup the mount options

Dave Chinner
2012-07-29T22:09:23Z

On Wed, Jul 25, 2012 at 09:11:37AM +0800, Wanlong Gao wrote:
> remove the mount options macro, use tokens instead.
>
> change from V6: (Dave)
> 1. switch GFP_NOFS to GFP_KERNEL
>
> change from V5: (Dave)
> 1. fix a string leak.
> 2. leave the show options to raw numbers.
>
> change from V4: (as Dave suggested)
> 1. suffix_match_int avoid overflow.
> 2. convert the return style to be consistent with others.
> 3. move the "intarg" init above the switch.
> 4. move match_strdup to a help function.
> 5. collapsed Opt_biosize and Opt_allocsize.
> 6. make a consistent deprecated message.

Looks good now. Thanks for takingthe time to get this right!

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com