From: Christoph Hellwig <hch@infradead.org>
To: Ben Myers <bpm@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks
Date: Fri, 13 Jul 2012 02:16:51 -0400 [thread overview]
Message-ID: <20120713061651.GA20909@infradead.org> (raw)
In-Reply-To: <20120712230421.GE29979@sgi.com>
On Thu, Jul 12, 2012 at 06:04:21PM -0500, Ben Myers wrote:
> xfs/fs/xfs/xfs_buf.c:1062: error: static declaration of ???xfs_bdstrat_cb??? follows non-static declaration
> xfs/fs/xfs/xfs_buf.h:183: error: previous declaration of ???xfs_bdstrat_cb??? was here
>
> CONFIG_XFS_DEBUG was not set.
>
> I'm happy to have caught that before pulling this in. Most of the time I am
> testing with CONFIG_XFS_DEBUG=y. I'll fix it up.
The one in the header should just go away, that's why I moved
xfs_bwrite.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-07-13 6:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 10:00 [PATCH 0/2] buffer caches fixes for Linux 3.5 Christoph Hellwig
2012-07-02 10:00 ` [PATCH 1/2] xfs: prevent recursion in xfs_buf_iorequest Christoph Hellwig
2012-07-03 0:27 ` Dave Chinner
2012-07-02 10:00 ` [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks Christoph Hellwig
2012-07-03 0:28 ` Dave Chinner
2012-07-03 16:05 ` Christoph Hellwig
2012-07-03 23:29 ` Dave Chinner
2012-07-04 5:57 ` Christoph Hellwig
2012-07-04 8:32 ` Dave Chinner
2012-07-04 15:16 ` Christoph Hellwig
2012-07-12 23:04 ` Ben Myers
2012-07-13 6:16 ` Christoph Hellwig [this message]
2012-07-13 6:24 ` [PATCH 2/2 v2] " Christoph Hellwig
2012-07-13 16:59 ` Ben Myers
2012-07-13 19:12 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713061651.GA20909@infradead.org \
--to=hch@infradead.org \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox