From: Christoph Hellwig <hch@infradead.org>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v3] xfs: probe data buffer from page cache for unwritten extents
Date: Tue, 17 Jul 2012 03:18:02 -0400 [thread overview]
Message-ID: <20120717071802.GA15473@infradead.org> (raw)
In-Reply-To: <4FF29C2C.2000407@oracle.com>
On Tue, Jul 03, 2012 at 03:15:56PM +0800, Jeff Liu wrote:
> Hello,
>
> This is v3 of the patch.
>
> We can trigger BUG() in xfs_seek_data() if met two unwritten without data or hole extents at last version.
> So making the extents map reading in loop could solve it.
>
> Sorry, Am not yet try the repeated holes scenario according to Dave's comments as lack of X64 test env, still
> waiting for it ready. But this patch is already too long delayed, I have worked it out one weeks ago.
> So I'd like to post it because of it could handle repeated hole/unwritten extents well in a loop, and I also improved
> xfstests:286 with those cases for the verification, will post it soon.
>
> v2->v3:
> Tested by Mark, hit BUG() for continuous unwritten extents without data wrote.
> * xfs_seek_data(), remove BUG() and having extents map search in loop.
The patch looks good. But as question by Mark I wonder if it's a good
idea to just improve xfs_seek_data, but not xfs_seek_hole.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-07-17 7:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 7:15 [PATCH v3] xfs: probe data buffer from page cache for unwritten extents Jeff Liu
2012-07-09 16:41 ` Mark Tinguely
2012-07-19 14:39 ` Jie Liu
2012-07-17 7:18 ` Christoph Hellwig [this message]
2012-07-17 12:27 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717071802.GA15473@infradead.org \
--to=hch@infradead.org \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox