From: Dan Carpenter <dan.carpenter@oracle.com>
To: dchinner@redhat.com
Cc: xfs@oss.sgi.com
Subject: re: xfs: use discontiguous xfs_buf support in dabuf wrappers
Date: Wed, 18 Jul 2012 16:46:36 +0300 [thread overview]
Message-ID: <20120718134636.GA17265@elgon.mountain> (raw)
Hello Dave Chinner,
This is a semi-automatic email about new static checker warnings.
The patch 3605431fb973: "xfs: use discontiguous xfs_buf support in
dabuf wrappers" from Jun 22, 2012, leads to the following Smatch
complaint:
fs/xfs/xfs_da_btree.c:2113 xfs_da_get_buf()
error: we previously assumed 'bp' could be null (see line 2111)
fs/xfs/xfs_da_btree.c
2110 mapp, nmap, 0);
2111 error = bp ? bp->b_error : XFS_ERROR(EIO);
2112 if (error) {
2113 xfs_trans_brelse(trans, bp);
^^^^^^^^^^^^^^^^^^^^^^^^^^
If bp is NULL here then it causes an Oops.
2114 goto out_free;
2115 }
regards,
dan carpenter
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
reply other threads:[~2012-07-18 13:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718134636.GA17265@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=dchinner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox