* re: xfs: use discontiguous xfs_buf support in dabuf wrappers
@ 2012-07-18 13:46 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-07-18 13:46 UTC (permalink / raw)
To: dchinner; +Cc: xfs
Hello Dave Chinner,
This is a semi-automatic email about new static checker warnings.
The patch 3605431fb973: "xfs: use discontiguous xfs_buf support in
dabuf wrappers" from Jun 22, 2012, leads to the following Smatch
complaint:
fs/xfs/xfs_da_btree.c:2113 xfs_da_get_buf()
error: we previously assumed 'bp' could be null (see line 2111)
fs/xfs/xfs_da_btree.c
2110 mapp, nmap, 0);
2111 error = bp ? bp->b_error : XFS_ERROR(EIO);
2112 if (error) {
2113 xfs_trans_brelse(trans, bp);
^^^^^^^^^^^^^^^^^^^^^^^^^^
If bp is NULL here then it causes an Oops.
2114 goto out_free;
2115 }
regards,
dan carpenter
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-18 13:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-18 13:46 xfs: use discontiguous xfs_buf support in dabuf wrappers Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox