From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q79NFaeN237650 for ; Thu, 9 Aug 2012 18:15:36 -0500 Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id bA9sGmATe6Cui7nu for ; Thu, 09 Aug 2012 16:15:34 -0700 (PDT) Date: Fri, 10 Aug 2012 09:15:30 +1000 From: Dave Chinner Subject: Re: [PATCH v6 1/4] xfs: Remove type argument from xfs_seek_data()/xfs_seek_hole() Message-ID: <20120809231530.GZ2877@dastard> References: <501B6B62.7040303@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <501B6B62.7040303@oracle.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Jeff Liu Cc: xfs@oss.sgi.com On Fri, Aug 03, 2012 at 02:10:42PM +0800, Jeff Liu wrote: > The type is already indicated by the function naming explicitly, so this argument > can be omitted from those calls. > > Signed-off-by: Jie Liu Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs