From: Dave Chinner <david@fromorbit.com>
To: Tomas Racek <tracek@redhat.com>
Cc: lczerner@redhat.com, Ben Myers <bpm@sgi.com>,
Alex Elder <elder@kernel.org>,
"supporter:XFS FILESYSTEM" <xfs@oss.sgi.com>
Subject: Re: [PATCH v3] xfs: check for possible overflow in xfs_ioc_trim
Date: Fri, 10 Aug 2012 09:47:59 +1000 [thread overview]
Message-ID: <20120809234758.GE2877@dastard> (raw)
In-Reply-To: <1344503229-13022-1-git-send-email-tracek@redhat.com>
[ Trimmed lkml from cc list. There's no need to cc lkml on XFS
specific stuff. ]
[ Trimmed linux-xfs@vger.kernel.org as that is not a list any XFS
developer is subscribed to. ]
On Thu, Aug 09, 2012 at 11:07:09AM +0200, Tomas Racek wrote:
> If range.start or range.minlen is bigger than filesystem size, return
> invalid value error. This fixes possible overflow in BTOBB macro when
> passed value was nearly ULLONG_MAX.
>
> Signed-off-by: Tomas Racek <tracek@redhat.com>
> ---
> fs/xfs/xfs_discard.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
> index f9c3fe3..4e07a56 100644
> --- a/fs/xfs/xfs_discard.c
> +++ b/fs/xfs/xfs_discard.c
> @@ -179,12 +179,14 @@ xfs_ioc_trim(
> * used by the fstrim application. In the end it really doesn't
> * matter as trimming blocks is an advisory interface.
> */
> + if (range.start >= XFS_FSB_TO_B(mp, mp->m_sb.sb_dblocks) ||
> + range.minlen > XFS_FSB_TO_B(mp, mp->m_sb.sb_dblocks))
> + return -XFS_ERROR(EINVAL);
That's not correct for minlen. The maximum minlen we can
support is the length of the largest freespace extent in the
filesystem, and that is limited to the size of an AG. i.e.
XFS_FSB_TO_B(mp, XFS_ALLOC_AG_MAX_USABLE(mp))
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-08-09 23:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 9:07 [PATCH v3] xfs: check for possible overflow in xfs_ioc_trim Tomas Racek
2012-08-09 23:47 ` Dave Chinner [this message]
2012-08-13 8:16 ` Tomas Racek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809234758.GE2877@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=elder@kernel.org \
--cc=lczerner@redhat.com \
--cc=tracek@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox