From: Dave Chinner <david@fromorbit.com>
To: Tomas Racek <tracek@redhat.com>
Cc: lczerner@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfstests: Use upstream version of fstrim instead of the local one
Date: Wed, 15 Aug 2012 07:39:11 +1000 [thread overview]
Message-ID: <20120814213911.GM2877@dastard> (raw)
In-Reply-To: <1344937201-17389-1-git-send-email-tracek@redhat.com>
On Tue, Aug 14, 2012 at 11:40:01AM +0200, Tomas Racek wrote:
> Local version of fstrim was dropped so that we depend on upstream
> version now. _require_fstrim was added to check if fstrim is available
> in the system and _test_batched_discard to check if we can run fstrim
> on certain mountpoint.
>
> Also tests 251 and 260 were modified to reflect this change.
Looks OK, but the only thing I'd suggest is using a $FSTRIM_PROG
variable rather than fsttrim directly. see how $XFS_IO_PROG is set
up in common.rc and copy that.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-08-14 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 9:40 [PATCH v2] xfstests: Use upstream version of fstrim instead of the local one Tomas Racek
2012-08-14 21:39 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814213911.GM2877@dastard \
--to=david@fromorbit.com \
--cc=lczerner@redhat.com \
--cc=tracek@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox