From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix uninitialised variable in xfs_rtbuf_get()
Date: Thu, 16 Aug 2012 11:42:18 -0500 [thread overview]
Message-ID: <20120816164218.GY29979@sgi.com> (raw)
In-Reply-To: <1343710551-24998-1-git-send-email-david@fromorbit.com>
Hi Dave,
On Tue, Jul 31, 2012 at 02:55:51PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Results in this assert failure in generic/090:
>
> XFS: Assertion failed: *nmap >= 1, file: fs/xfs/xfs_bmap.c, line: 4363
> .....
> Call Trace:
> [<ffffffff814680db>] xfs_bmapi_read+0x6b/0x370
> [<ffffffff814b64b2>] xfs_rtbuf_get+0x42/0x130
> [<ffffffff814b6f09>] xfs_rtget_summary+0x89/0x120
> [<ffffffff814b7bfe>] xfs_rtallocate_extent_size+0xce/0x340
> [<ffffffff814b89f0>] xfs_rtallocate_extent+0x240/0x290
> [<ffffffff81462c1a>] xfs_bmap_rtalloc+0x1ba/0x340
> [<ffffffff81463a65>] xfs_bmap_alloc+0x35/0x40
> [<ffffffff8146f111>] xfs_bmapi_allocate+0xf1/0x350
> [<ffffffff8146f9de>] xfs_bmapi_write+0x66e/0xa60
> [<ffffffff8144538a>] xfs_iomap_write_direct+0x22a/0x3f0
> [<ffffffff8143707b>] __xfs_get_blocks+0x38b/0x5d0
> [<ffffffff814372d4>] xfs_get_blocks_direct+0x14/0x20
> [<ffffffff811b0081>] do_blockdev_direct_IO+0xf71/0x1eb0
> [<ffffffff811b1015>] __blockdev_direct_IO+0x55/0x60
> [<ffffffff814355ca>] xfs_vm_direct_IO+0x11a/0x1e0
> [<ffffffff8112d617>] generic_file_direct_write+0xd7/0x1b0
> [<ffffffff8143e16c>] xfs_file_dio_aio_write+0x13c/0x320
> [<ffffffff8143e6f2>] xfs_file_aio_write+0x1c2/0x1d0
> [<ffffffff81174a07>] do_sync_write+0xa7/0xe0
> [<ffffffff81175288>] vfs_write+0xa8/0x160
> [<ffffffff81175702>] sys_pwrite64+0x92/0xb0
> [<ffffffff81b68f69>] system_call_fastpath+0x16/0x1b
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good.
Reviewed-by: Ben Myers <bpm@sgi.com>
Regards,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-08-16 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 4:55 [PATCH] xfs: fix uninitialised variable in xfs_rtbuf_get() Dave Chinner
2012-08-16 16:42 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816164218.GY29979@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox