From: Ben Myers <bpm@sgi.com>
To: Alex Elder <elder@inktank.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: kill struct declarations in xfs_mount.h
Date: Thu, 16 Aug 2012 13:24:40 -0500 [thread overview]
Message-ID: <20120816182440.GZ29979@sgi.com> (raw)
In-Reply-To: <501943B1.5090300@inktank.com>
On Wed, Aug 01, 2012 at 09:56:49AM -0500, Alex Elder wrote:
> I noticed that "struct xfs_mount_args" was still declared in
> "fs/xfs/xfs_mount.h". That struct doesn't even exist any more (and
> is obviously not referenced elsewhere in that header file). While
> in there, delete four other unneeded struct declarations in that
> file.
>
> Doing so highlights that "fs/xfs/xfs_trace.h" was relying indirectly
> on "xfs_mount.h" to be #included in order to declare "struct
> xfs_bmbt_irec", so add that declaration to resolve that issue.
>
> Signed-off-by: Alex Elder <elder@inktank.com>
Looks fine to me.
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-08-16 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 14:56 [PATCH] xfs: kill struct declarations in xfs_mount.h Alex Elder
2012-08-16 18:24 ` Ben Myers [this message]
2012-08-17 12:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816182440.GZ29979@sgi.com \
--to=bpm@sgi.com \
--cc=elder@inktank.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox