public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: unlock the AGI buffer when looping in xfs_dialloc
Date: Thu, 16 Aug 2012 15:53:26 -0500	[thread overview]
Message-ID: <20120816205326.GA29979@sgi.com> (raw)
In-Reply-To: <20120807060202.GA4005@infradead.org>

Hey Christoph,

On Tue, Aug 07, 2012 at 02:02:02AM -0400, Christoph Hellwig wrote:
> Also update some commens in the area to make the code easier to read.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

This seems to fix a regression that was introduced in

commit 55d6af64, 'xfs: refactor xfs_ialloc_ag_select'

Christoph, could you comment on why this has not caused problems in testing?  I
am sort of suprised we haven't had any ill effects.

I'll add this patch into our next pull request.

Thanks,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      parent reply	other threads:[~2012-08-16 20:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07  6:02 [PATCH] xfs: unlock the AGI buffer when looping in xfs_dialloc Christoph Hellwig
2012-08-07 14:26 ` Mark Tinguely
2012-08-09 23:49 ` Dave Chinner
2012-08-16 20:53 ` Ben Myers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120816205326.GA29979@sgi.com \
    --to=bpm@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox