From: Carlos Maiolino <cmaiolino@redhat.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH V2] Make inode64 a remountable option
Date: Thu, 16 Aug 2012 23:23:24 -0300 [thread overview]
Message-ID: <20120817022324.GC16013@orion.usersys.redhat.com> (raw)
In-Reply-To: <1345169925-18927-1-git-send-email-cmaiolino@redhat.com>
Sorry, added a wrong element in the loop, sending a V3 now.
On Thu, Aug 16, 2012 at 11:18:45PM -0300, Carlos Maiolino wrote:
> Actually, there is no reason about why a user must umount and mount a XFS
> filesystem to enable 'inode64' option. So, this patch makes this a remountable
> option.
>
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> fs/xfs/xfs_super.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index bdaf4cb..d5ef8c7 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -120,12 +120,13 @@ mempool_t *xfs_ioend_pool;
> * in the future, too.
> */
> enum {
> - Opt_barrier, Opt_nobarrier, Opt_err
> + Opt_barrier, Opt_nobarrier, Opt_inode64, Opt_err
> };
>
> static const match_table_t tokens = {
> {Opt_barrier, "barrier"},
> {Opt_nobarrier, "nobarrier"},
> + {Opt_inode64, "inode64"},
> {Opt_err, NULL}
> };
>
> @@ -1043,6 +1044,7 @@ xfs_fs_remount(
>
> while ((p = strsep(&options, ",")) != NULL) {
> int token;
> + int i = 0;
>
> if (!*p)
> continue;
> @@ -1055,6 +1057,20 @@ xfs_fs_remount(
> case Opt_nobarrier:
> mp->m_flags &= ~XFS_MOUNT_BARRIER;
> break;
> + case Opt_inode64:
> +
> + for (i = 0; i < mp->m_sb.agcount; i++) {
> + struct xfs_perag *pag;
> +
> + pag = xfs_perag_get(mp, index);
> + pag->pagi_inodeok = 1;
> + pag->pagf_metadata = 0;
> + xfs_perag_put(pag);
> + }
> + mp->m_flags &= ~(XFS_MOUNT_32BITINODES |
> + XFS_MOUNT_SMALL_INUMS);
> + mp->m_maxagi = i;
> + break;
> default:
> /*
> * Logically we would return an error here to prevent
> --
> 1.7.11.2
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
--Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-08-17 2:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 2:18 [PATCH V2] Make inode64 a remountable option Carlos Maiolino
2012-08-17 2:23 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120817022324.GC16013@orion.usersys.redhat.com \
--to=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox