From: Christoph Hellwig <hch@infradead.org>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH V3] Make inode64 a remountable option
Date: Fri, 17 Aug 2012 13:33:46 -0400 [thread overview]
Message-ID: <20120817173346.GA18347@infradead.org> (raw)
In-Reply-To: <1345171178-10447-1-git-send-email-cmaiolino@redhat.com>
On Thu, Aug 16, 2012 at 11:39:38PM -0300, Carlos Maiolino wrote:
> + case Opt_inode64:
> +
> + for (i = 0; i < mp->m_sb.sb_agcount; i++) {
> + struct xfs_perag *pag;
> +
> + pag = xfs_perag_get(mp, i);
> + pag->pagi_inodeok = 1;
> + pag->pagf_metadata = 0;
> + xfs_perag_put(pag);
> + }
> + mp->m_flags &= ~(XFS_MOUNT_32BITINODES |
> + XFS_MOUNT_SMALL_INUMS);
> + mp->m_maxagi = i;
Can you factor this into a little helper? I hate having lots of code
and especially loops inside of deep switch statements.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-08-17 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 2:39 [PATCH V3] Make inode64 a remountable option Carlos Maiolino
2012-08-17 5:04 ` Dave Chinner
2012-08-17 12:24 ` Christoph Hellwig
2012-08-17 14:49 ` Carlos Maiolino
2012-08-17 17:34 ` Christoph Hellwig
2012-08-17 17:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120817173346.GA18347@infradead.org \
--to=hch@infradead.org \
--cc=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox