From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: Re: [PATCH V3] Make inode64 a remountable option
Date: Fri, 17 Aug 2012 13:34:49 -0400 [thread overview]
Message-ID: <20120817173449.GB18347@infradead.org> (raw)
In-Reply-To: <20120817144950.GA17092@orion.usersys.redhat.com>
On Fri, Aug 17, 2012 at 11:49:50AM -0300, Carlos Maiolino wrote:
> I don't think there is any lock protection around m_flags, I did a search on the
> code and couldn't find anything protecting it. At a first glance though, I don't
> think there is a need to protect it once this flag is managed only during super
> operations - mount/umount/remount -
> Also, I *think* the sb->s_umount rw_semaphore is enough for protection, once it
> protects the whole mount/umount operation, but I'm 100% sure of it.
Seems like rw_semaphore takes care of it, and we already have a trace
when setting XFS_MOUNT_FS_SHUTDOWN. I guess it's fine as is for now,
but I'd love to have comment explaining why it's safe.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-08-17 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 2:39 [PATCH V3] Make inode64 a remountable option Carlos Maiolino
2012-08-17 5:04 ` Dave Chinner
2012-08-17 12:24 ` Christoph Hellwig
2012-08-17 14:49 ` Carlos Maiolino
2012-08-17 17:34 ` Christoph Hellwig [this message]
2012-08-17 17:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120817173449.GB18347@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox